Custom metric-profile list from flag #111
Conversation
rsevilla87
force-pushed
the
issue-110
branch
from
5c573a7
to
c8a5562
Compare
rsevilla87
force-pushed
the
issue-110
branch
from
c8a5562
to
521cbcc
Compare
rsevilla87
changed the title
rsevilla87
changed the title
rsevilla87
force-pushed
the
issue-110
branch
from
521cbcc
to
ebd8acb
Compare
rsevilla87
force-pushed
the
issue-110
branch
6 times, most recently
from
23ef16c
to
a07d303
Compare
Signed-off-by: Raul Sevilla <[email protected]>
rsevilla87
force-pushed
the
issue-110
branch
from
a07d303
to
2dedd4d
Compare
|
This looks like it it exactly what I need. Thank you! |
rsevilla87
changed the title
Great, have you tested it? |
| profileType, _ := cmd.Root().PersistentFlags().GetString("profile-type") | ||
| switch ProfileType(profileType) { | ||
| case Reporting: | ||
| metricsProfiles = []string{"metrics-report.yml"} | ||
| case Regular: |
There was a problem hiding this comment.
We might want to remove this from the help message in ocp.go as well
There was a problem hiding this comment.
I don't want to touch any of the current functionality, for now, in a follow-up PR my idea is to deprecate the profile-type flag too
There was a problem hiding this comment.
Without regular case being handled here, I did not see a point in having it in the help description as its is dead code and might be misleading for users.
Can you provide more details on deprecating profile-type flag please? It might break our CI.
There was a problem hiding this comment.
it will break it, for sure, for that reason I prefer to address that separately
+1 it works in my use case in openshift-ci: openshift/release#57412 |
Type of change
Description
Small implementation of the --metrics-profile flag
Related Tickets & Documents
Checklist before requesting a review