-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom metric-profile list from flag #111
Conversation
5c573a7
to
c8a5562
Compare
c8a5562
to
521cbcc
Compare
521cbcc
to
ebd8acb
Compare
23ef16c
to
a07d303
Compare
Signed-off-by: Raul Sevilla <[email protected]>
a07d303
to
2dedd4d
Compare
This looks like it it exactly what I need. Thank you! |
Great, have you tested it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - @davdhacs can you confirm you have tested and this fits the needs for the ACS team?
profileType, _ := cmd.Root().PersistentFlags().GetString("profile-type") | ||
switch ProfileType(profileType) { | ||
case Reporting: | ||
metricsProfiles = []string{"metrics-report.yml"} | ||
case Regular: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to remove this from the help message in ocp.go
as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to touch any of the current functionality, for now, in a follow-up PR my idea is to deprecate the profile-type flag too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without regular
case being handled here, I did not see a point in having it in the help description as its is dead code and might be misleading for users.
Can you provide more details on deprecating profile-type flag please? It might break our CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will break it, for sure, for that reason I prefer to address that separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
+1 it works in my use case in openshift-ci: openshift/release#57412 |
Type of change
Description
Small implementation of the --metrics-profile flag
Related Tickets & Documents
Checklist before requesting a review